fix: skip duplicate "Add to topics" commit on repeated submissions#88
Open
raghav-potdar wants to merge 1 commit into
Open
fix: skip duplicate "Add to topics" commit on repeated submissions#88raghav-potdar wants to merge 1 commit into
raghav-potdar wants to merge 1 commit into
Conversation
… topics if topic it's already present. Avoiding one extra commit on multiple submission for same problem
Author
|
This PR partly resolves Issue #85 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a LeetCode solution is submitted multiple times (e.g. resubmitting an already-accepted problem), LeetHub creates an extra git commit with the message Add to topics. on every submission — even though the problem was already present in the README topic tables and nothing actually changed.
Blank extra commit on every submission
Fix
Snapshot the README content before the append loop. After the loop — but before calling sortTopicsInReadme — compare the result to the snapshot. If the content is identical (nothing new was added), exit early and skip both sorting and uploading entirely.